-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable makefiles #639
Portable makefiles #639
Conversation
|
|
dfcefdb
to
9acade5
Compare
For comparison, GNU Make build with current master (fails for parallel make due to issue fixed by 9acade5, so cherry-picked it for comparability). Parallel
|
Comparing the installed footprint contents, there are differences in PERL module areas (different wording/order of JSON markup in |
Signed-off-by: Jim Klimov <[email protected]>
…n (breaks parallel make sometimes) Signed-off-by: Jim Klimov <[email protected]>
… make syntax (do not require fiddling with GNU make envvars on non-Linux builds) Signed-off-by: Jim Klimov <[email protected]>
9acade5
to
4897884
Compare
Docs updated, spell checker happy, done on my side for now :) |
yes the idea of the cpanfile-*snapshot files is to allow for reproducible builds with a given set of modules and a particular perl version ... updating these files for different perl version would certainly be cool ... |
Avoid GNUisms, allowing less fuss on BSD and illumos installs.
Checked with sequential and parallel builds/installs using Sun make on OpenIndiana 2023.10 and BSD make on FreeBSD 12.
"Screenshots" follow in posts below. To summarize them, comparing tests with GNU, Sun and BSD make this PR does not add regressions (or none were detected), and fixes parallel builds on top of that.
NOTE/question: @oetiker : Files like
thirdparty/cpanfile-5.38.snapshot
orthirdparty/cpanfile-5.32.snapshot
(depending on OS perl version) appear and are explicitly not git-ignored nor cleaned away. One for 5.30 is in fact git-tracked. Should others be added?